Repository navigation
fix(deps): update module github.com/mudler/yip to v1.27.1 - #6171
Conversation
v1.27.1 stops only_os steps from re-reading the machine info while other steps template it. That race made the JSON encoding of the info panic (mudler/yip#344) and silently dropped the rest of a stage. Signed-off-by: mauro-agent <mauro-agent@mrls.xyz> Co-developed-by: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Mauro Morales <contact@mauromorales.com>
auroraboot/go.mod pins yip on its own and replaces the root module, so the image build failed with go mod tidy needed after the root bump. Co-developed-by: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Mauro Morales <contact@mauromorales.com>
19b697c to
5b10947
Compare
|
@ci-robbot please QA |
|
Picking this up for QA. |
QA Result: PASSTested head
On master, a failed run exits 2 after only 6 of 60 templated steps and 6 of 60 On the PR, every run rendered Fresh boot of the PR ISO with only a cidata user seed, before anything else was run: Summary: The bump fixes the parallel-stage panic in the Kairos binary itself, on a real booted node as well as in a container: 0 panics in 600 runs, against 56 in 600 on master, with templates and |
Bumps
github.com/mudler/yipfrom v1.27.0 to v1.27.1.v1.27.1 fixes mudler/yip#344 with mudler/yip#361. The agent and immucore run yip stages in parallel. A step with
only_osre-read the machine info while another step was templating it, and the JSON encoding of that info panicked withreflect: slice index out of range. The panic kills the process, the rest of the stage is skipped and boot goes on, so a cloud-config can be silently dropped on about 5 percent of boots (the figure from the yip issue). The fix removes the re-read.Only
go.modandgo.sumchange.Testing
go build ./agent/... ./immucore/... ./cmd/...passes.go test ./agent/pkg/cloudinit/... ./sdk/collector/... ./sdk/machine/...passes.go test ./agent/pkg/config/reports the same 7 failures with yip v1.27.0 and with v1.27.1, so they are not from this bump. They look like file-system tests that cannot run in my sandbox.AI disclosure
I used Claude Code to prepare this change. A human has not yet read the diff line by line; it is a two-line dependency bump.